10up / component-library

A library of barebones front-end components built with WordPress and accessibility in mind.

https://baseline.10up.com/

MIT License

58 stars 11 forks source link

Release/2.0.3 #105

Closed devinle closed 2 years ago

devinle commented 2 years ago

Description of the Change

This PR adds the following:

support for nested tabs
typo found in the tabs instructions

Benefits

This PR will allow a user to add tabs within tabs for nested functionality.

Possible Drawbacks

Verification Process

Add markup for tabs with nested tabs to confirm functionality.

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.

Applicable Issues

github-actions[bot] commented 2 years ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	1	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

codecov-commenter commented 2 years ago

Codecov Report

Merging #105 (fd049a5) into trunk (9cd1fbe) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk     #105   +/-   ##
=======================================
  Coverage   66.90%   66.90%           
=======================================
  Files          12       12           
  Lines         855      855           
  Branches      196      196           
=======================================
  Hits          572      572           
  Misses        229      229           
  Partials       54       54

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9cd1fbe...fd049a5. Read the comment docs.

cypress[bot] commented 2 years ago

Test summary

11 • 0 • 1 • 0

Run details


Project	@10up/component-library
Status	Passed
Commit	43a9261f0d ℹ️
Started	Mar 9, 2022 9:39 PM
Ended	Mar 9, 2022 9:40 PM
Duration	00:47 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 98

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard