Closed ajmaurya99 closed 1 year ago
0 | 11 | 1 | 0 | 0 |
Details:
Merge a856b9efc185772165c651910ac53ebf428e32be into 9b40823739f5e4f99683651182c5... | |||
Project: @10up/component-library | Commit: a8c18874eb ℹ️ |
||
Status: Passed | Duration: 00:46 💡 | ||
Started: Apr 10, 2023 7:15 AM | Ended: Apr 10, 2023 7:15 AM |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Closing as duplicate of https://github.com/10up/component-library/pull/92
@joesnellpdx and @ajmaurya99 this branch has a solve for the aria-expanded issues listed above that the issue it was closed in favor for does not address. Could we re-open it and get it merged in? I've had to use this fix twice in the last week.
I'm also seeing this issue on the latest version (2.1.3)
Thanks @tinacastillo1 @jacobdubailcadmv I will raise an updated PR in this week. Thanks for the report.
Patch coverage: 100.00
% and project coverage change: +0.46
:tada:
Comparison is base (
9b40823
) 66.82% compared to head (a8c1887
) 67.28%.:exclamation: Current head a8c1887 differs from pull request most recent head a856b9e. Consider uploading reports for the commit a856b9e to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@tinacastillo1 @jacobdubailcadmv Could you both please confirm if this PR has the change that you were expecting. Thanks :)
@tinacastillo1 @jacobdubailcadmv Could you both please confirm if this PR has the change that you were expecting. Thanks :)
This is working perfectly 😄
Description of the Change
The Aria Expanded value is not getting updated via
openSubmenu
andcloseSubmenu
callbacks, So I have updated thearia-expanded
attribute based on the callbacks.Also added
$submenu
reference toonSubmenuOpen
andonSubmenuClose
callbacks. Added reference to the submenu on theonSubmenuOpen()
callback. Added reference to the submenu on theonSubmenuClose()
callback.Benefits
Accessibility Enhancement.
Verification Process
Open the Navigation dropdown menu item. Click on the sibling menu item. The aria-expanded value gets updated based on the openSubmenu and closeSubmenu callbacks.
Checklist:
Applicable Issues
https://github.com/10up/component-library/issues/106