Description of the Change

Fixes #120 by using the forEach index instead of this.count to generate a unique ID for tooltips.

Alternate Designs

Incrementing this.count in place like below also worked in local testing, but I think the forEach index is more reliable.

tip.setAttribute('id', `tool_tip_${this.count++}`);

Benefits

Possible Drawbacks

This is a quick fix for my current project, but there will still be duplicate tooltip IDs on the page if the Tooltip class is instantiated multiple times on the page with different selectors.

The unique IDs should be generated using the uuid package, or the Tooltip class should allow passing in an ID prefix. Or the number of Tooltip instances could be tracked in the global scope.

Verification Process

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.


Project	@10up/component-library
Status	Passed
Commit	8c347f9dec ℹ️
Started	Sep 20, 2022 2:38 PM
Ended	Sep 20, 2022 2:39 PM
Duration	00:43 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 105

10up / component-library

Use forEach index to generate unique ID #121

Description of the Change

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

Applicable Issues

120

Test summary

Run details