Closed jacobdubailcadmv closed 1 year ago
![]() |
![]() |
![]() |
![]() |
![]() |
Details:
Merge bee14569ecfcdb264b09409c528300aa79d7125d into 0ef0f4a2f8b691f5ebc73ea0cb73... | |||
Project: @10up/component-library | Commit: 4bf6bc594c ℹ️ |
||
Status: Passed | Duration: 00:45 💡 | ||
Started: Apr 13, 2023 6:34 PM | Ended: Apr 13, 2023 6:35 PM |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Patch coverage: 100.00
% and project coverage change: +0.50
:tada:
Comparison is base (
9b40823
) 66.82% compared to head (c534dff
) 67.32%.:exclamation: Current head c534dff differs from pull request most recent head d2c2c20. Consider uploading reports for the commit d2c2c20 to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Description of the Change
Adds the parent menu ID to the submenu IDs to ensure unique IDs. This change prevents duplicate IDs.
Alternate Designs
An alternative solution is to use the Web Crypto API (randomUUID) or the UUID package.
Benefits
This change will prevent duplicate IDs on the page, which fails validation and has a11y implications, when using multiple navigation components on the same page.
Possible Drawbacks
n/a
Verification Process
I built the code
npm run build
and confirmed the change on a project that was affected by #141.Checklist:
Applicable Issues
141