10up / component-library

A library of barebones front-end components built with WordPress and accessibility in mind.
https://baseline.10up.com/
MIT License
59 stars 12 forks source link

Demo code missing site-menu-toggle class #28

Closed nicholasio closed 2 years ago

nicholasio commented 3 years ago

Describe the bug The example code for both HTML and Wordpress needs a site-menu-toggle class added to the main toggle element.

To Reproduce Steps to reproduce the behavior:

  1. Create a navigation output based on the markup provided.
  2. Load the navigation in a browser window
  3. Notice that on desktop, the navigation toggle still appears and its visibility isn't controlled by the script.

Expected behavior When resizing from mobile to desktop, the navigation toggle should disappear, since it isn't required when the navigation becomes fully displayed.

Desktop (please complete the following information):

Additional context By adding the site-menu-toggle class to the main toggle "a" element, this issue should be resolved.