10up / curator

Select specific posts from across multiple post types to combine together and control the ordering.
38 stars 7 forks source link

'Undo' of trash/uncurate action does not work #30

Open AaronHolbrook opened 8 years ago

AaronHolbrook commented 8 years ago

http://d.pr/i/1huTV/MjwUmXiL

@ayebare this would complement the work you just did with re-labeling trash to uncurate nicely. Mind taking a look?

ayebare commented 8 years ago

Thanks, will do @AaronHolbrook

ayebare commented 8 years ago

@AaronHolbrook Currently the curated post is deleted when a post is put in trash. I suggest changes below to have trashing fixed. This is the proposed relationship between the original post and curated post for each action.

Action: Uncurate original post

Action: Curate post

Action: Trash curated post.

Action : Trash original post.

Action: Untrash original post

Action: Untrash Original post

Action: Untrash Curated post

Please let me know if I could have missed something fundamental.

AaronHolbrook commented 8 years ago

@ayebare I like that you broke out each action possible.

I think we can do this without having a real 'trash' for curated posts but instead rely on the originating post's meta store. FYI I believe 'trash' is disabled for the cur-curator post type

Action: Uncurate Original post

Action: Curate post

Action: Trash curated post

Action: Trash original post

Action: Untrash original post

Action: Untrash curated post

ayebare commented 8 years ago

Created a PR for the fix.