10up / distributor

Share content between your websites.
https://distributorplugin.com
GNU General Public License v2.0
637 stars 156 forks source link

Fix/update admin icon #1132

Closed zach-adams closed 1 year ago

zach-adams commented 1 year ago

Description of the Change

Closes #1119

Updates the admin SVG icon to have roughly the same width & height so it no long appears squished in the admin menus or in the block editor plugin. The main benefit realized is that it will no longer mildly annoy me whenever I notice it's squished 😉

The SVG has been reworked & simplified to smooth out several issues that appeared when the original was enlarged. It's down to just 2 path elements which reduces file size greatly (8KB to 1.5KB) and it should make it somewhat easier to update in the future.

Applies to:

Examples of how it looked before vs with the updated icon:

Before Updated
old-icon
2023-09-06_20-52-3LOLjpfR 2023-09-06_20-53-KP7F9TLm
2023-09-06_20-54-Jz3aw2Ri 2023-09-06_20-54-XzgYtqjI
2023-09-06_20-55-3IA3Vm8h 2023-09-06_20-55-YxvIwLWi
2023-09-06_20-58-twzCj9ad 2023-09-06_20-57-WqLyGegZ

How to test the Change

  1. Install and activate Distributor plugin
  2. Check admin main menu "Distributor" icon is updated & showing correctly
  3. Check that the updated menu icon color matches other admin menu icons including on hover & when it's active while visiting a Distributor setting sub-page (should auto-update to white when active)
  4. Check Posts/Pages list page & verify the Distributor column icon is updated & showing correctly
  5. Open a Post/Page block editor and verify the icon in the Distributor tab in the sidebar page settings is updated & showing correctly

Changelog Entry

Fixed - Admin icon has been updated so it has the same width/height

Credits

Props @zach-adams

Checklist:

zach-adams commented 1 year ago

@ravinderk Moved icon data string to a utility function, let me know if that looks alright