search

10up / distributor

Share content between your websites.
https://distributorplugin.com
GNU General Public License v2.0
618 stars 156 forks source link

Fix cypress tests #1242

Open kirtangajjar opened 2 weeks ago

kirtangajjar commented 2 weeks ago

Description of the Change

Fixes E2E tests

Closes #1241

How to test the Change

Changelog Entry

Fixed - E2E tests

Credits

Props @kirtangajjar

Checklist:

kirtangajjar commented 2 weeks ago

The pending work here is described in https://github.com/10up/distributor/pull/1237#issuecomment-2209395488. Basically as we have removed quotes around command here, we need to do the same in https://github.com/10up/cypress-wp-utils/blob/develop/src/commands/wp-cli.ts#L21 unless we find a different solution.

iamdharmesh commented 2 weeks ago

@kirtangajjar PR looks good to me just added one note to discuss it.

we need to do the same in https://github.com/10up/cypress-wp-utils/blob/develop/src/commands/wp-cli.ts#L21 unless we find a different solution.

I have already raised PR https://github.com/10up/cypress-wp-utils/pull/128 to handle this in https://github.com/10up/cypress-wp-utils/

Just curious on why E2E test GH action check is not triggered on this PR 🤔

Thank you.

jeffpaul commented 2 weeks ago

@iamdharmesh looks like e2e tests are running with latest commit 🤷🏼