search

10up / generator-wp-make

A Yeoman generator for making WordPress things
184 stars 42 forks source link

Adding in tests for util>tree::getSubTree function #76

Closed fuhton closed 8 years ago

fuhton commented 8 years ago

These tests cover the use cases that I encountered this week as I tried to modify this application. Hopefully they'll be able to be a little instructive as to how these functions works as well as confirming that the functionality I flushed out earlier this week remains the same.

lkwdwrd commented 8 years ago

I want to try and run the test before approving. Code looks good though. Should be able to run them tonight and just verify we're :100:

Luke Woodward – Associate Director of Engineering 10up Inc. http://10up.com | luke.woodward@10up.com | @lkwdwrd

On Thu, Jul 7, 2016 at 9:34 AM, Nicholas notifications@github.com wrote:

Assigned #76 https://github.com/10up/generator-wp-make/pull/76 to @lkwdwrd https://github.com/lkwdwrd.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/10up/generator-wp-make/pull/76#event-715799548, or mute the thread https://github.com/notifications/unsubscribe/ABztOpELRzfa2SeWk3wpccKLqZBLWjjOks5qTQ5xgaJpZM4JHJKK .

fuhton commented 8 years ago

@lkwdwrd FYI - just pushed another test suite that tests some core functionality of the utility tool library.

lkwdwrd commented 8 years ago

OK, once I got user error out of the way, the tests run perfectly. This is a good start to get some coverage in here. Going to go ahead and merge this in.