search

10up / generator-wp-make

A Yeoman generator for making WordPress things
184 stars 42 forks source link

Fix the grunt process in v1-rewrite #78

Closed fuhton closed 8 years ago

fuhton commented 8 years ago

Fix the output of grunt modules and tasks to format into the correct directories. Add in ES6 support via babel and browserify. Add eslint and jscs for linting purposes. Format the default JS file to pass these linters. Fix the creation of TestCase.php so initial tests can successfully pass.

This is a first pass and some iterations will be happening to browserify/babel/ES6 loading in a future commit. CSS modules will also need another pass.

fuhton commented 8 years ago

@lkwdwrd @allenmoore Any thoughts on this?

lkwdwrd commented 8 years ago

In the next few days, I'm going to try pulling this in for more testing. If all looks good I'll plan on merging it.

lkwdwrd commented 8 years ago

@fuhton I tested everything and ran into some issues. The biggest being that prompting now uses promises and doesn't accept a callback function. It's a little o_O that they would do something like that and not make it back compat, but oh well.

I submitted a PR to your branch with the updates to make everything work with promises, clear some warnings, and update all the npm deps. After that I was able to fully generate and run a plugin in WP.

Let's get this one updated and merged and then I'll rebase my extensions PR.