Update generated gitignore file

10up / generator-wp-make

A Yeoman generator for making WordPress things

184 stars 42 forks source link

Update generated gitignore file #93

Open timwright12 opened 8 years ago

timwright12 commented 8 years ago

Can we update the generated gitignore file with some more standard additions? Suggestion:

/release/
/vendor/
composer.lock
phpunit.xml
.idea

# Sass
.sass-cache
*.map

# NPM
node_modules/

# Editors
*.esproj
*.tmproj
*.tmproject
tmtags
.*.sw[a-z]
*.un~
Session.vim
*.swp

# Mac OSX
.DS_Store
._*
.Spotlight-V100
.Trashes

# Windows
Thumbs.db
Desktop.ini

cmmarslender commented 8 years ago

I'm particularly a fan of the more specific /vendor/ and /release/ so we don't accidentally ignore a folder called vendor inside of say, a "sass" folder 👍

cmmarslender commented 8 years ago

Before we merge this, we should remove the ignore on the composer.lock file - want to make sure we are able to deploy known composer dependencies, and need that file to do so.

lkwdwrd commented 8 years ago

Agree with this idea -- The general team is pushing to get the V1 rewrite done, which will include these. We're trying not to make many changes to the legacy version at this point, but the plan is to look closely at the files output after build, including the .gitignore, which yes, should really not have the composer.lock file in it amongst the other things mentioned here.

I'll leave this issue open for anyone wanting to write up the PR, or as a reminder as we finish out version 1. if we push version 1 before a PR comes through I'll close as wontfix.