10up / gutenberg-best-practices

Welcome to the 10up Gutenberg Best Practices!
https://gutenberg.10up.com
94 stars 25 forks source link

Homepage search has incorrect width #151

Closed AshutoshNanaware closed 2 months ago

AshutoshNanaware commented 11 months ago

Description of the Change

Homepage search has incorrect width: Fixed the width of dropdown to be same as search bar.

Closing #

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
10up-gutenberg-best-practices ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 5:45pm
fabiankaegy commented 11 months ago

Hey @AshutoshNanaware 👋

Thank you for working on this :)

The width is now looking great, however it is a little jarring that the height of the cyan backdrop element now also changes with the search element. Before this change the overlay actually was floating on top of the element. CleanShot 2023-12-11 at 22 48 44@2x

Ideally, that behavior would be retained. Just with the new width.

AshutoshNanaware commented 11 months ago

Hello @fabiankaegy ,

I've fixed the list element style issue. My apologies for not testing with some elements in the dropdown initially.

New dropdown: image

Current Dropdown UI: image