fix/caret: Fix caret and formatting issue

10up / insert-special-characters

A Special Character inserter for the WordPress block editor (Gutenberg).

https://wordpress.org/plugins/insert-special-characters/

GNU General Public License v2.0

71 stars 15 forks source link

fix/caret: Fix caret and formatting issue #225

Closed Sidsector9 closed 11 months ago

Sidsector9 commented 1 year ago

Description of the Change

Closes #34 Closes #208

How to test the Change

Please see the respective issues for testing instructions.

Changelog Entry

Fixed - Issue with blocks crashing due to faux caret Fixed - Issue with characters added to the beginning trimming text from the end

Credits

Props @dkotter @Sidsector9

Checklist:

[ ] I agree to follow this project's Code of Conduct.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my change.
[ ] All new and existing tests pass.

ankitguptaindia commented 11 months ago

@Sidsector9 This PR fixed the issues reported in both connected issues but I am facing issue in a specific scenario when user select whole content which has any special character.

It is showing This block has encountered an error and cannot be previewed.

Screenshot 2023-10-30 at 10 18 22 PM

https://github.com/10up/insert-special-characters/assets/6384299/b41885f9-798b-466f-8691-c105283e5b57

For QA Use only: RTL Sites: https://github.com/10up/insert-special-characters/assets/6384299/61e2a041-a334-4bb1-9b68-9485011e4735

ankitguptaindia commented 11 months ago

QA/Test Report- ✅

Testing Environment -

WordPress: 6.5-alpha-57029
PHP: 8.0.30
Server: nginx/1.16.0
Database: mysqli (Server: 5.7.28 / Client: 8.0.30)
Browser: Chrome 118.0.0.0
OS: macOS
Theme: Twenty Twenty-Four 1.0

Actual Results

Both Connected issues have been fixed. ✅
Issue Reported in QA Feedback has been addressed and fixed. ✅
Also tested in RTL & LTR sites, issues have been fixed. ✅

https://github.com/10up/insert-special-characters/assets/6384299/ce60cdaa-578e-4d58-bd53-5b77647b8b0b