search

10up / publisher-media-kit

Pre-configured Media Kit Page using Gutenberg Block Patterns.
https://wordpress.org/plugins/publisher-media-kit/
GNU General Public License v2.0
43 stars 6 forks source link

Editor Stylesheet does not need to be loaded outside of SCRIPT_DEBUG mode #174

Closed davisshaver closed 9 months ago

davisshaver commented 10 months ago

Describe the bug

I was tracking down a console error seen on a Newspack site using Publisher Media Kit.

tinymce.min.js:2 
       GET https://domain.com/wp-content/plugins/publisher-media-kit/dist/css/editor-style.min.css?wp-mce-49110-20201110 net::ERR_ABORTED 404 (Not Found)

This file does not appear to be built. It is not listed in the entrypoints: https://github.com/10up/publisher-media-kit/blob/develop/package.json#L60-L69

Should editor style be added as its own entrypoint to support this code? https://github.com/10up/publisher-media-kit/blob/develop/includes/core.php#L338-L353

Steps to Reproduce

Load New Post page with plugin enabled. Do not have SCRIPT_DEBUG enabled. Observe the 404.

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct