search

10up / restricted-site-access

Limit access to visitors who are logged in or allowed by IP addresses. Includes many options for handling blocked visitors.
http://10up.com/plugins/restricted-site-access-wordpress/
GNU General Public License v2.0
231 stars 47 forks source link

Gutenberg Conflict With Experminatal Disable TinyMCE Feature #285

Closed BrookeDot closed 3 months ago

BrookeDot commented 1 year ago

Describe the bug

I've been experiencing a bug that was driving me mad and finally was able to replicate it. I was unable to set the "message" field in the plugin's settings. Instead I just saw an empty field.

Screenshot 2023-10-24 153914

I was able to set a message with CLI;

~$ wp rsa set-mode message --text="Site is under development, please login"
Success: Site showing message to visitors.

When I started disabling plugin's I disabled Gutenberg and the filed returned:

Screenshot 2023-10-24 154923

Looking through the Gutenberg settings I found the "Disable TinyMCE and Classic block" setting. When this setting is enabled the message field does not appear.

Screenshot 2023-10-24 154008

Looking at the 's files I found the following: https://github.com/WordPress/gutenberg/blob/ae7df52f58baf6289c58b5da76a884ff400cfa3f/lib/experimental/disable-tinymce.php#L10-L20

I'm assuming the solution here is to ensure the "Reading" page is set to require the classic editor (or to upgrade the message field to use the Block Editor)

Steps to Reproduce

  1. Install Gutenberg
  2. Under Gutenberg > Experiences make sure TinyMCE is disabled (checkbox is checked)
  3. Make sure RSA is enabled
  4. Visit Settings > Reading and notice the missing message field/TinyMCE editor
  5. Disable the Gutenberg TinyMCE box (uncheck the box)
  6. Notice the settings return for RSA.

Screenshots, screen recording, code snippet

No response

Environment information

Tested on Windows, MacOS (several versions). Firefox, Brave, Edge, etc.

WordPress information

WordPress Version | 6.4 WordPress Multisite | No WordPress Memory Limit | 512M WordPress Debug Mode | No WordPress Debug Log | No WordPress Script Debug Mode | No WordPress Cron | Yes WordPress Alternate Cron | No Background tasks | Yes

NGINX

PHP 8.2.11

Code of Conduct

Sidsector9 commented 3 months ago

@BrookeDot Disabling TinyMCE is an experimental feature provided by the Gutenberg plugin and the usage should be avoided in production. I don't think this can be classified as a bug in RSA. @dkotter any thoughts on this?

dkotter commented 3 months ago

I think that's correct. Something we can keep an eye on to see if this ever gets merged into WordPress core and fix then but otherwise if anyone runs into this problem, we can suggest they disable that setting in Gutenberg

Sidsector9 commented 3 months ago

Closing this for now as not fixing.