Closed dhanendran closed 3 months ago
@faisal-alvi I have addressed your comments.
@ravinderk @faisal-alvi I have addressed your comments.
@faisal-alvi The bulk select checkbox working fine for me. Can you test this again please?
@dhanendran Thanks for the changes. I retested again in a different setup but the bulk select is not working there too. I am on WP v6.5.4, could you please try to replicate it in that version if you are not already on it?
@dhanendran @faisal-alvi I've checked with a different setup but the bulk select is not working.
Testing Environment
@faisal-alvi Removed the extra line and added a fix for the E2E tests.
Additionally, I'm curious about the necessity of custom JS code for bulk edit and bulk checkbox select functionalities. Why doesn't the WordPress core handle these features by default?
A custom Bulk Edit JS was already there and Bulk Select JS is something I have added after investigating the issue. We are not using an actual custom post type or WP_LIST_TABLE due to which the core functionality for bulk select or bulk edit was not working so we need to add those functionality. Let me know if you have any other questions. Thanks!
@faisal-alvi @dhanendran it would be great to generate a screenshot/screencast of this, add that to the dotorg directory, and then include in the screenshots section of the readme.txt file.
@jeffpaul I haven't seen any screenshots added in the dotorg/readme yet. Should I include screenshots of the other plugin areas/pages as well? Also, do GIFs work on dotorg? A GIF might be better than a static screenshot for demonstrating bulk edit.
Description of the Change
Added option to Quick edit and Bulk edit redirect's HTTPS status and Force Https meta on the post list table.
Closes #98
How to test the Change
Changelog Entry
Credits
Props @dhanendran
Checklist: