10up / safe-redirect-manager

A simple HTTP redirection plugin for WordPress.
https://wordpress.org/plugins/safe-redirect-manager
GNU General Public License v2.0
314 stars 82 forks source link

Quick Edit and Bulk edit #350

Closed dhanendran closed 3 months ago

dhanendran commented 1 year ago

Description of the Change

Added option to Quick edit and Bulk edit redirect's HTTPS status and Force Https meta on the post list table.

Closes #98

Screenshot 2023-09-08 at 4 05 20 PM Screenshot 2023-09-08 at 4 05 29 PM

How to test the Change

  1. Goto Safe Redirect Manager's list page
  2. Hover over any redirect and confirm the "Quick Edit" option available
  3. On the Quick Edit, confirm the Https status code and Force Https meta fields available to edit
  4. Confirm the updates are saved to the post
  5. Select multiple posts and select the "Edit" option from the bulk actions dropdown
  6. Confirm the data updated to respective posts

Changelog Entry

Added - Option to quick edit and bulk edit redirect's https status and force https meta.

Credits

Props @dhanendran

Checklist:

dhanendran commented 1 year ago

@faisal-alvi I have addressed your comments.

dhanendran commented 4 months ago

@ravinderk @faisal-alvi I have addressed your comments.

@faisal-alvi The bulk select checkbox working fine for me. Can you test this again please?

faisal-alvi commented 4 months ago

@dhanendran Thanks for the changes. I retested again in a different setup but the bulk select is not working there too. I am on WP v6.5.4, could you please try to replicate it in that version if you are not already on it?

350-gif-2

qasumitbagthariya commented 4 months ago

QA Update ❌


@dhanendran @faisal-alvi I've checked with a different setup but the bulk select is not working.

Jun-16-2024 15-22-05

Testing Environment

- WordPress: 6.5.4 - Theme: Twenty Twenty-Four 1.1 - PHP: 8.0.30 - Web Server: Nginx 1.20.2 - Browser: Chrome - OS: macOS Ventura 13.3
mehul0810 commented 3 months ago

@faisal-alvi Removed the extra line and added a fix for the E2E tests.

Additionally, I'm curious about the necessity of custom JS code for bulk edit and bulk checkbox select functionalities. Why doesn't the WordPress core handle these features by default?

A custom Bulk Edit JS was already there and Bulk Select JS is something I have added after investigating the issue. We are not using an actual custom post type or WP_LIST_TABLE due to which the core functionality for bulk select or bulk edit was not working so we need to add those functionality. Let me know if you have any other questions. Thanks!

jeffpaul commented 2 months ago

@faisal-alvi @dhanendran it would be great to generate a screenshot/screencast of this, add that to the dotorg directory, and then include in the screenshots section of the readme.txt file.

faisal-alvi commented 2 months ago

@jeffpaul I haven't seen any screenshots added in the dotorg/readme yet. Should I include screenshots of the other plugin areas/pages as well? Also, do GIFs work on dotorg? A GIF might be better than a static screenshot for demonstrating bulk edit.