Closed philipjohn closed 10 months ago
@ravinderk Are you referring to the "Silencing errors..." warning? If so, that's not the PHPCS issue this PR is addressing.
Without this PR, PHP 8.2 compatibility checks with PHPCS report the following:
FILE: safe-redirect-manager/inc/functions.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
336 | WARNING | INI directive 'auto_detect_line_endings' is deprecated since PHP 8.1
| | (PHPCompatibility.IniDirectives.RemovedIniDirectives.auto_detect_line_endingsDeprecated)
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
After this change, that deprecation warning is gone.
Description of the Change
While #327 resolved a deprecation warning, the code is still flagged by PHPCS as being problematic. This change builds on #327 to add the
phpcs:ignore
statement so that the code doesn't hold up any processes unnecessarily by flagging something that's no longer an issue.Closes #283
How to test the Change
<config name="testVersion" value="8.1" />
in phpcs.xml)Changelog Entry
Credits
Props @philipjohn
Checklist: