10up / safe-svg

Enable SVG uploads and sanitize them to stop XML/SVG vulnerabilities in your WordPress website.
https://wordpress.org/plugins/safe-svg/
GNU General Public License v2.0
266 stars 31 forks source link

Fix | Slow load times due to svg_dimensions #154

Closed sksaju closed 9 months ago

sksaju commented 11 months ago

Description of the Change

We have refactored the svg_dimensions function to calculate dimensions using the existing attachment meta.

Closes #75 and #151

How to test the Change

Changelog Entry

Added - New feature Changed - Existing functionality Deprecated - Soon-to-be removed feature Removed - Feature Fixed - Bug fix Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

Sidsector9 commented 11 months ago

@sksaju the PR is in draft, is this ready for review?

sksaju commented 11 months ago

@sksaju the PR is in draft, is this ready for review?

Not yet. I just need to fix the unit test issue, which I can do early next week :)

jeffpaul commented 9 months ago

@darylldoyle back to you for review

sksaju commented 9 months ago

Looking good! Ignoring E2E tests as it doesn't look like they're fully set-up

Thanks @darylldoyle I already fixed the E@E issue here https://github.com/10up/safe-svg/pull/154/commits/d0b5b8a2a7d9776bfa639f9b912ccf090686e01c :)