Closed sksaju closed 9 months ago
@sksaju the PR is in draft, is this ready for review?
@sksaju the PR is in draft, is this ready for review?
Not yet. I just need to fix the unit test issue, which I can do early next week :)
@darylldoyle back to you for review
Looking good! Ignoring E2E tests as it doesn't look like they're fully set-up
Thanks @darylldoyle I already fixed the E@E issue here https://github.com/10up/safe-svg/pull/154/commits/d0b5b8a2a7d9776bfa639f9b912ccf090686e01c :)
Description of the Change
We have refactored the
svg_dimensions
function to calculate dimensions using the existing attachment meta.Closes #75 and #151
How to test the Change
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: