10up / simple-page-ordering

Order your pages and other hierarchical post types with simple drag and drop right from the standard page list.
https://wordpress.org/plugins/simple-page-ordering/
GNU General Public License v2.0
143 stars 22 forks source link

`TAXONOMY_NAME` constant is going to lead to a conflict. #139

Closed peterwilsoncc closed 1 year ago

peterwilsoncc commented 1 year ago

Describe the bug

In plugin's main file, the constant TAXONOMY_NAME is defined

https://github.com/10up/simple-podcasting/blob/a940466b009ea99cb7f2513c3d454a20211e0c7f/simple-podcasting.php#L20-L21

It's used is several locations throughout the plugin to refer to the podcasting the taxonomy. As such a generic term, it's going to lead to a confict at some point, as suggested by these search results .

I suggest the constant be:

Steps to Reproduce

N/A

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

peterwilsoncc commented 1 year ago

Sorry, wrong simple-p... plugin.