fix/164: Show pagination when Sort by Order is clicked - Githubissues

10up / simple-page-ordering

Order your pages and other hierarchical post types with simple drag and drop right from the standard page list.

https://wordpress.org/plugins/simple-page-ordering/

GNU General Public License v2.0

143 stars 22 forks source link

fix/164: Show pagination when Sort by Order is clicked #165

Closed Sidsector9 closed 9 months ago

Sidsector9 commented 9 months ago

Closes #164

Description of the Change

In this PR, we additionally send posts_per_page as -1 when "Sort By Order" is clicked to enable pagination.

How to test the Change

Changelog Entry

Fixed - Hidden pagination in admin screen when Sort by Order is clicked

Credits

Props @tlovett1 @dkotter @Sidsector9

Checklist:

[ ] I agree to follow this project's Code of Conduct.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my change.
[ ] All new and existing tests pass.

Sidsector9 commented 9 months ago

@dkotter that's a good catch. I took an alternative approach and tested it with child, as well as child of child elements. Can you take a look?