upkeep/163: Fix fatal error on PHP 5.6 - Githubissues

10up / simple-page-ordering

Order your pages and other hierarchical post types with simple drag and drop right from the standard page list.

https://wordpress.org/plugins/simple-page-ordering/

GNU General Public License v2.0

141 stars 22 forks source link

upkeep/163: Fix fatal error on PHP 5.6 #166

Closed Sidsector9 closed 8 months ago

Sidsector9 commented 9 months ago

Description of the Change

This PR does the following:

Moves the class Simple_Page_Ordering to a separate file.
Require class-simple-page-ordering.php only when platform validation passes.

Closes #163

How to test the Change

Please follow steps from the issue.

Changelog Entry

Fixed - Fatal errors on PHP 5.6

Credits

Props @peterwilsoncc @Sidsector9

Checklist:

[ ] I agree to follow this project's Code of Conduct.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my change.
[ ] All new and existing tests pass.

Sidsector9 commented 9 months ago

Thanks for testing @iamdharmesh The files you're seeing is expected as you can also see them in the vendors directory. I'll resolve this in the next release of WP Compat Validator Tool.