10up / simple-page-ordering

Order your pages and other hierarchical post types with simple drag and drop right from the standard page list.
https://wordpress.org/plugins/simple-page-ordering/
GNU General Public License v2.0
141 stars 22 forks source link

Bump WordPress "tested up to" version 6.4 #177

Closed jeffpaul closed 8 months ago

jeffpaul commented 8 months ago

Description of the Change

Bumps WordPress "tested up to" version 6.4

Closes #171.

How to test the Change

Changelog Entry

Changed - Bump WordPress "tested up to" version 6.4.

Credits

Props @qasumitbagthariya @jeffpaul

Checklist:

jeffpaul commented 8 months ago

@qasumitbagthariya I'm seeing failures on trunk when bumping to WP 6.4. Are you certain your tests passed?

qasumitbagthariya commented 8 months ago

@jeffpaul It works for 2.6.0 but does not work with the trunk branch.

qasumitbagthariya commented 8 months ago

@faisal-alvi

The functionality works when downloading the plugin from https://wordpress.org/plugins/simple-page-ordering/ but looks like an issue when we download from the git release zip and trunk branch.

Can you please check from your end?

The issue is not a blocker for this PR so I'm approving this PR. ✅

cc @jeffpaul

faisal-alvi commented 8 months ago

The issue is not a blocker for this PR so I'm approving this PR.

@qasumitbagthariya since the issue doesn't seem to be related to WordPress 6.4, could you please open a separate issue ticket for it? Once that's done, we can merge this PR.

qasumitbagthariya commented 8 months ago

@faisal-alvi

Already the Issue has been created https://github.com/10up/simple-page-ordering/issues/178