`PLUGIN_VERSION` is too generic

10up / simple-page-ordering

Order your pages and other hierarchical post types with simple drag and drop right from the standard page list.

https://wordpress.org/plugins/simple-page-ordering/

GNU General Public License v2.0

149 stars 23 forks source link

`PLUGIN_VERSION` is too generic #78

Closed dinhtungdu closed 2 years ago

dinhtungdu commented 2 years ago

Is your enhancement related to a problem? Please describe.

In https://github.com/10up/simple-page-ordering/pull/74, we introduced a new constant named PLUGIN_VERSION. IMO that constant is too generic and has a higher chance to be conflicted with other plugins/themes. I think we should change it to one that is specific to Simple Page Ordering.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

jeffpaul commented 2 years ago

Totally agree, nice catch. SIMPLE_PAGE_ORDERING_VERSION might be better.