Closed cadic closed 2 years ago
Converting to draft as it needs improvement in push-deploy GitHub Action: change .gitattributes to .distignore workflow
The deploy process was tested with command:
rsync -rc --exclude-from=".distignore" . trunk/ --delete --delete-excluded
@peterwilsoncc this is ready to review now
@cadic looks like a merge conflict that needs to be resolved. @peterwilsoncc pinging you for reminder on code review here... thanks!
@cadic some feedback for you here, if you're not able to get to this please ping the OSP for someone else to pick this up and help finish it off... thanks!
Description of the Change
This PR changes the build tool from grunt to https://github.com/10up/10up-toolkit
dist
(added to .gitignore)npm run build
,npm run dev
andnpm run makepot
cypress
andpush-deploy
workflows to include the build stepCloses #79
Possible Drawbacks
1
Keep attention to the push-deploy GitHub Actions workflow. Before this change, compiled assets were hold in the repository and was ready to deploy without any additional steps. After this change, a build step is required.
2
Before this change, the
SCRIPT_DEBUG
php constant was used to force enqueueing the source JS. After this change, thenpm run dev
command starts the watch process, saves the debugging version of the JS and CSS files with sourcemaps. No additional setup needed for assets debugging.Verification Process
npm install
npm run build
dist
and pot file inlocalization
The push-deploy workflow was tested with a set of commands:
The resulting trunk folder contain the correct list of files.
Checklist:
Changelog Entry
Credits
Props @cadic