10up / simple-page-ordering

Order your pages and other hierarchical post types with simple drag and drop right from the standard page list.
https://wordpress.org/plugins/simple-page-ordering/
GNU General Public License v2.0
149 stars 23 forks source link

Upgrade grunt to 10up-toolkit #97

Closed cadic closed 2 years ago

cadic commented 2 years ago

Description of the Change

This PR changes the build tool from grunt to https://github.com/10up/10up-toolkit

Closes #79

Possible Drawbacks

1

Keep attention to the push-deploy GitHub Actions workflow. Before this change, compiled assets were hold in the repository and was ready to deploy without any additional steps. After this change, a build step is required.

2

Before this change, the SCRIPT_DEBUG php constant was used to force enqueueing the source JS. After this change, the npm run dev command starts the watch process, saves the debugging version of the JS and CSS files with sourcemaps. No additional setup needed for assets debugging.

Verification Process

  1. Clone the repo
  2. Run npm install
  3. Perform npm run build
  4. Expected to have assets in dist and pot file in localization
  5. Expected all plugin features to work

The push-deploy workflow was tested with a set of commands:

The resulting trunk folder contain the correct list of files.

Checklist:

Changelog Entry

Changed - Replaced Grunt with 10up-toolkit

Credits

Props @cadic

cadic commented 2 years ago

Converting to draft as it needs improvement in push-deploy GitHub Action: change .gitattributes to .distignore workflow

cadic commented 2 years ago

The deploy process was tested with command:

rsync -rc --exclude-from=".distignore" . trunk/ --delete --delete-excluded

@peterwilsoncc this is ready to review now

jeffpaul commented 2 years ago

@cadic looks like a merge conflict that needs to be resolved. @peterwilsoncc pinging you for reminder on code review here... thanks!

jeffpaul commented 2 years ago

@cadic some feedback for you here, if you're not able to get to this please ping the OSP for someone else to pick this up and help finish it off... thanks!