10up / simple-podcasting

A simple podcasting solution for WordPress.
https://wordpress.org/plugins/simple-podcasting/
GNU General Public License v2.0
186 stars 30 forks source link

Manipulating the podcast block causes the podcast to be removed from the feed. #293

Open dabowman opened 6 months ago

dabowman commented 6 months ago

Describe the bug

After making some updates to my podcast episode pages today, I discovered that all my episodes no longer showed up on any podcasting services. After some investigation it seems that grouping or un-grouping the podcast audio embed block causes it to remove the podcast selection. This means that the episode no longer publishes in the feed and will be removed from podcast services.

It seems like it basically un-checks the box in the block settings when it's grouped or un-grouped. The tricky part is that you can select the podcast you want to publish to in two places—the block settings and the post settings. The boxes in the block settings and the post settings are somewhat synchronized but when you check or un-check the box in the block settings it doesn't visually change the box in the post settings until you reload the page—even though it seems to actually be changing that setting behind the scenes. This means that you can group/ungroup the podcast block—which usually de-selects the block, hiding its settings so you can't see what you just did—update your post—seeing the checkbox selected next to your podcast—and go on your merry way not realizing that you just un-published your episode. If you reload the editor you see that the podcast is now un-checked in the post settings and the block settings both.

Hopefully this makes sense! I'll include a video showing the problem in action.

Steps to Reproduce

Embed a podcast episode in a post, group it, see that the podcast has been de-selected from the settings.

Screenshots, screen recording, code snippet

https://github.com/10up/simple-podcasting/assets/5473066/8964944a-6b3d-4cf0-9546-04516583db7d

Environment information

No response

WordPress information

No response

Code of Conduct