search

10up / simple-podcasting

A simple podcasting solution for WordPress.
https://wordpress.org/plugins/simple-podcasting/
GNU General Public License v2.0
186 stars 30 forks source link

Fix podcast title #295

Open kirtangajjar opened 4 months ago

kirtangajjar commented 4 months ago

Description of the Change

This PR removes the Podcast customisation logic. The main reason being that since the change was added in the first github commit of this project 6 years ago, there was a bug in code because of which the podcast title was never changed. This changed with this PR, which tried to fix it, but the only problem with this fix is that there is no way to set the podcasting_title term meta.

For users who have been using this plugin for years, it would appear that the behavior of the plugin has been changed. Since we've anyway made the podcast title filterable, anyone who wants to modify the podcast title can use the filter.

Closes #292.

How to test the Change

  1. Checkout PR branch
  2. Open podcast feed and ensure that the podcast title does not contain site name.

Changelog Entry

Fixed - Podcast title changing

Credits

Props @kirtangajjar

Checklist:

peterwilsoncc commented 4 months ago

@kirtangajjar Am I able to clarify what you are intending for the RSS feed's title to be on this pull request?

On this branch the result is Podcast name – Site name On the develop branch the result is Site name » Podcast name

Is that the change you are intending or are you intending the feed to simply be titled Podcast name?

kirtangajjar commented 4 months ago

@kirtangajjar Am I able to clarify what you are intending for the RSS feed's title to be on this pull request?

On this branch the result is Podcast name – Site name On the develop branch the result is Site name » Podcast name

Is that the change you are intending or are you intending the feed to simply be titled Podcast name?

Oh thanks for noticing that. I just wanted to preserve the legacy behavior of the plugin, and I thought that the legacy behaviour does not include site name. I missed the site title there.

The original ticket mentions that they didn't want site name in feed, but I think the current PR preserves legacy behaviour so it should be good? Or do you feel it would be best to just have podcast name in the title? I can update the PR for that as well.

peterwilsoncc commented 1 month ago

@kirtangajjar The order of the podcast name and title is reversed in the feed's title on this branch compared to develop. It's cool if that was intentional but I wanted to be sure that was the case.