10up / simple-podcasting

A simple podcasting solution for WordPress.
https://wordpress.org/plugins/simple-podcasting/
GNU General Public License v2.0
185 stars 30 forks source link

Ensure that the selected podcast term doesn't get removed from the podcast block settings. #322

Closed iamdharmesh closed 1 week ago

iamdharmesh commented 2 months ago

Description of the Change

PR fixes the issues reported in https://github.com/10up/simple-podcasting/issues/313#issuecomment-2364568916

How to test the Change

  1. Create a post.
  2. Add a podcast block.
  3. Choose a podcast term from the post sidebar panel and make sure selected term get reflected in editor block preview.
  4. Save the post and refresh the page. Ensure that selected podcast terms remains unchanged and same podcast term display in frontend.

Changelog Entry

Fixed - Ensure that the selected podcast term doesn't get removed from the podcast block settings. Removed - The postcast terms selector from the podcast block settings.

Credits

Props @dkotter @iamdharmesh

Checklist:

jeffpaul commented 1 month ago

@iamdharmesh is there still work pending here or can this open up for review?

iamdharmesh commented 1 month ago

@jeffpaul This is still in WIP. I am mainly blocked on how we want to proceed with the taxonomy settings (point 3 of this comment https://github.com/10up/simple-podcasting/issues/313#issuecomment-2364568916 and https://github.com/10up/simple-podcasting/issues/313#issuecomment-2379627439). Could you please share your thoughts on how we should proceed?

jeffpaul commented 3 weeks ago

@iamdharmesh just responded in https://github.com/10up/simple-podcasting/issues/313#issuecomment-2453229527, sorry for the delay