10up / simple-podcasting

A simple podcasting solution for WordPress.
https://wordpress.org/plugins/simple-podcasting/
GNU General Public License v2.0
186 stars 30 forks source link

[WIP] Ensure that the selected podcast term doesn't get removed from the podcast block settings. #322

Open iamdharmesh opened 1 month ago

iamdharmesh commented 1 month ago

Description of the Change

As reported in one of the issues in https://github.com/10up/simple-podcasting/issues/313#issuecomment-2364568916, the podcast term was not being set in the podcast block when it was configured at the post level. This issue was caused by a bug in the useEffect code, which has been resolved by this PR.

How to test the Change

  1. Create a post.
  2. Add a podcast block.
  3. Choose a podcast term from the post sidebar panel.
  4. Select the podcast block and check the selected podcast terms in the podcast settings. Ensure they match what is selected at the post level.
  5. Save the post and refresh the page. Ensure the podcast term selected in the podcast block settings remains unchanged.

Note: I have noticed that updating the podcast term selection at the block level is not reflected at the post level until the post is saved. This is due to the custom podcast term panel we are using at the post level, which needs to be updated.

Changelog Entry

Fixed - Ensure that the selected podcast term doesn't get removed from the podcast block settings.

Credits

Props @dkotter @iamdharmesh

Checklist:

jeffpaul commented 2 weeks ago

@iamdharmesh is there still work pending here or can this open up for review?

iamdharmesh commented 2 weeks ago

@jeffpaul This is still in WIP. I am mainly blocked on how we want to proceed with the taxonomy settings (point 3 of this comment https://github.com/10up/simple-podcasting/issues/313#issuecomment-2364568916 and https://github.com/10up/simple-podcasting/issues/313#issuecomment-2379627439). Could you please share your thoughts on how we should proceed?