Test against WP 5.4 - Githubissues

10up / simple-podcasting

A simple podcasting solution for WordPress.

https://wordpress.org/plugins/simple-podcasting/

GNU General Public License v2.0

187 stars 30 forks source link

Test against WP 5.4 #80

Closed jeffpaul closed 4 years ago

jeffpaul commented 5 years ago

Is your enhancement related to a problem? Please describe. Once WordPress 5.4 is released, we'll want to test Simple Podcasting to see if any incompatibility issues arise.

Describe the solution you'd like

[x] test Simple Podcasting on WP 5.4
[ ] open issues for any incompatibilities noted in testing
[ ] resolve issues identified in testing
[x] bump "tested up to" version
[ ] if code changes needed due to incompatibilities, ship a plugin release, otherwise use "Plugin asset/readme update" action to update "tested up to" version on .org repo

Designs n/a

Describe alternatives you've considered none

Additional context none

Waka867 commented 4 years ago

@jeffpaul I can go through this one

jeffpaul commented 4 years ago

@Waka867 awesome, many thanks!

jeffpaul commented 4 years ago

@Waka867 how did your testing go with Simple Podcasting and WordPress 5.3?

Waka867 commented 4 years ago

@jeffpaul Sorry haven't gotten to this yet due to some stuff coming up over the holidays. Will try to hit this tomorrow am!

Waka867 commented 4 years ago

@jeffpaul Sorry for the delay, I went through Simple Podcasting and found a problem that I've opened an issue for here

Here are my notes from the testing I did. Other than that issue, I found no other problems with the plugin.

Notes Adding podcasts functions properly Edit podcast page all fields submit properly XMl RSS Feed doc generates correctly with the right info Feed URL properly lists each podcast item as they are added URL validated with podba.se Gutenberg block properly usable On post view, preview, and blog listing pages, gutenberg podcast block does not play, no console errors shown. Time shows 0:00/0:00 and podcast doesn't load, file plays when added on the edit page. Adding conventional audio block works fine. Server php/apache error logs show no errors on day or even week of test Submitted issue #81

jeffpaul commented 4 years ago

@Waka867 thanks again on this. I'm going to leave this issue open until we get through #81 and can work to finish up the checklist items to get to bumping the "tested up to" value.

jeffpaul commented 4 years ago

Note that I updated this from WP 5.3 to 5.4 as the new major release is pending the end of this month.