Align PHP minimum version checks

10up / windows-azure-storage

Use the Microsoft Azure Storage service to host your website's media files.

https://wordpress.org/plugins/windows-azure-storage/

BSD 2-Clause "Simplified" License

58 stars 46 forks source link

Align PHP minimum version checks #202

Closed radeno closed 6 months ago

radeno commented 8 months ago

Description of the Change

After merging https://github.com/10up/windows-azure-storage/commit/3b7f2fa776cb5a3d2111ce94258245971a4c1517 there was introduced helper method. Align PHP version checking

Closes #

How to test the Change

Changelog Entry

Added - New feature Changed - Existing functionality Deprecated - Soon-to-be removed feature Removed - Feature Fixed - Bug fix Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

[x] I agree to follow this project's Code of Conduct.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my change.
[x] All new and existing tests pass.

jeffpaul commented 8 months ago

@10up/open-source-practice could use a quick code review on this for the 4.4.0 release, thanks!

faisal-alvi commented 8 months ago

@jeffpaul @ravinderk Should we use https://github.com/10up/wp-compat-validation-tool instead of adding manual checks across all plugins? There is set_php_min_required_version( 8.0 ) function that seems useful here.

jeffpaul commented 8 months ago

@faisal-alvi yes, probably worth updating to that newly available tool

radeno commented 8 months ago

Fixed PR. It was made by a hot needle in Github web app. Sorry, I called incorrect PHP function. It should be was_site_meets_php_requirements. Now it is fixed @ravinderk @faisal-alvi @jeffpaul

ravinderk commented 8 months ago

@radeno can you use wp-compat-validation-tool library to validate the PHP version?

Sample code: https://github.com/10up/maps-block-apple/pull/174/files

cc: @jeffpaul @faisal-alvi

radeno commented 8 months ago

@ravinderk from my point of view this is bigger change. My PR aligned two different PHP versions (7.4 and 8.0) checks currently implemented to just one (8.0). That's all. Implementing another dependency and removing current logic should not prevent deploying this module as soon as possible.