Closed hugosolar closed 2 weeks ago
@hugosolar Simple yet effective update. Approved. cc @jeffpaul
@hugosolar I'm noting now that this PR had e2e failures as does #230, so hoping you can look into that either in a new PR or perhaps updated on #230?
Description of the Change
this change closes #191 I was able to investigate this issue and enabling performance lab and enable webp option causes the plugin just uploads
webp
converted images from intermediate images excluding the original.Because of this plugin uses
wp_generate_attachment_metadata
hook to upload images to blob container, there seems to be a priority conflict with WordPress native conversion from the original image at the moment of uploading to the container. Increasing the hook priority to 10, make the plugin work as expected and upload thewebp
converted original image and also the original image itself which is the expected behavior (as referred by the official documentation). After uploading to the blob container and checked the meta data I'm able to see the original jpeg image is kept into the meta fieldAlso, the
windows_azure_storage_info
attachment meta field is keeping both imagesHow to test the Change
_wp_attachment_metadata
windows_azure_storage_info
_wp_attached_file
should point to the webp original versionChangelog Entry
Credits
@hugosolar, @ali-awwad (for reporting it)
Checklist: