Add pagination for existing relationships

crawfjs commented 4 years ago

Description of the Change

This change implements pagination for the existing relationships (PickerList) and resolves an issue where relationships are removed when updating a post and there are more than ten relationships defined. This limited the number of relationships that the plugin would allow to ten.

Alternate Designs

Another consideration was to handle pagination server side. This would have been a heavier implementation, including a move from a save-all approach, to individual change sets / transactions.

Benefits

This is a light weight approach for the pagination, encapsulating within the component itself.

Possible Drawbacks

Since pagination is handled on the client side, it implements a select all approach. Could put a really high limit here (2000), but we could run into the data loss issue again.

Verification Process

For the changes to the project / setup, run any of these npm run build-js or npm run dev-build-js or npm run watch-js

Functionality was tested in the following scenarios:

No relationships
One page worth of relationships (<=10)
Multiple pages worth of relationships
Adding relationships (one page of relationships, multiple pages of relationships)
Deleting relationships (on first page, last page, etc)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my change.
[x] All new and existing tests passed.

Applicable Issues

n/a

Changelog Entry

jeffpaul commented 4 years ago

@crawfjs welcome to WP Content Connect and thanks for the PR, it's greatly appreciated! I'm checking with a teammate to see if they can give this a review and either provide feedback or merge this in, will keep you posted as that happens and if there are any questions or updates needed. Thanks again!

s3rgiosan commented 2 years ago

@jeffpaul are there any plans to release this enhancement any time soon? We have a client that needs the number of relationships "limit" bumped.

jeffpaul commented 2 years ago

@s3rgiosan up to now @rickalee has been the core maintainer here, but if you feel comfortable leading things on a release then I'd be happy to help you get things tagged/released?

jeffpaul commented 1 year ago

@s3rgiosan any interest in resolving the conflicts here for @rickalee to review/approve for release on this as well?

s3rgiosan commented 1 year ago

Sure. I can take a look tomorrow.

jeffpaul commented 7 months ago

@s3rgiosan any interest in resolving the conflicts here for @rickalee to review/approve for release on this as well?

10up / wp-content-connect