10up / wp-scaffold

10up WordPress project scaffold.
MIT License
204 stars 48 forks source link

Fix: Block registrations in Themes in WordPress 6.0 by removing the filter of `plugins_url` #103

Closed fabiankaegy closed 2 years ago

fabiankaegy commented 2 years ago

This patch is what I would recommend to any project that registers blocks with block.json files in a theme. The patch can be applied at any time before updating to WordPress 6.0. So we can get ahead of the actual update.

The need for this fix was outlined in #99

Since the patch was just merged into core today and we don't jet have a beta version of 6.0 to be more confident of the patch actually landing in there I am keeping this as a draft PR.

Closes #99

fabiankaegy commented 2 years ago

I have tested this today with the actual Beta 1 of WordPress 6.0 and can confirm that it is working as intended 👍

I would recommend to hold till Beta 2 to ensure that the patch does not get removed before we merge this in and inform the team. That would be on April 19.

fabiankaegy commented 2 years ago

Just to provide an update here. I've also tested Beta 2 & Beta 3 and the patch is still working as intended.