Feature/css reset update

joesnellpdx commented 1 year ago

Description of the Change

Change the css reset from normalize to modern-normalize
Add some general css reset enhancements
Update package.json files

Closes #182

How to test the Change

Assuming local setup already running as expected.
Remove node modules files across project (root, plugin, theme)
At root, make sure on correct verson of npm with npm use
Run npm install at the root
Run npm run start to compile files
Test front end output. Should notice box-sizing: border-box; on any divs.

Changelog Entry

Added - modern-normalize npm package to theme Changed - import modern-normalize from node_modules in theme - replacing normalize Changed - package.json files due to the package updates Removed - normalize from package.json Fixed - Includes box-sizing: border-box; by default

Credits

Props @10up/frontend-leads, @devinle, @fabiankaegy, and @dainemawer

Checklist:

[x] I agree to follow this project's Code of Conduct.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my change (N/A)
[x] All new and existing tests pass.

joesnellpdx commented 1 year ago

@fabiankaegy

You had mentioned adding some default CSS (WordPress specific). Will you help define what those are?

In the scaffold, we have the wordpress.css file.

I also added reset.css and included the isolation declaration from your reset for stacking context.

While I'm in here - I'd love to add any common additions you may have been thinking of. Please let me know when you have a moment. Thanks!

Once we have that figured out, I'll have the FE Leads review, then move this forward.

joesnellpdx commented 1 year ago

@fabiankaegy Your CR issues have been resolved. Please review again - and let me know if there are any other CSS resets you would like to see added at this time. Thanks!

joesnellpdx commented 11 months ago

@darylldoyle this is ready for review and merged once approved.

@fabiankaegy - your previous issues have been resolved.

Let me know if you have any questions or concerns.

darylldoyle commented 11 months ago

Thanks @joesnellpdx!

@fabiankaegy any chance you can take a look at this since you reviewed before, please?

darylldoyle commented 11 months ago

@joesnellpdx I don't seem to have the permissions to merge in this repo now, but since this is approved, you should be good to do so!

10up / wp-scaffold