search

10up / wp-scaffold

10up WordPress project scaffold.
MIT License
184 stars 46 forks source link

#187 Added @10up/babel-preset-default to dev dependencies. #188

Closed jamesmorrison closed 4 months ago

jamesmorrison commented 12 months ago

Description of the Change

Adds @10up/babel-preset-default to dev dependencies

Closes #187

How to test the Change

  1. Note and test the repeatable steps on #187 to see the error on the trunk branch
  2. Switch to this branch and run: npm install; npm run build
  3. Build should complete successfully

Changelog Entry

Fixed - Missing dependency

Credits

Props @jamesmorrison

Checklist:

fabiankaegy commented 4 months ago

@jamesmorrison is this still relevant?

nicholasio commented 4 months ago

I don't think so... this shoulnd't be needed and I haven't seen reports of this problem.

jamesmorrison commented 4 months ago

This can be closed; I opened the PR because I had the same issue on multiple projects, but haven’t had any issues with this in recent releases.