Feature/code feedback

[gthayer]

Feedback Thorsten shared in Slack:

• use WP_CLI::runCommand() instead of Exec to inherit the environment properly
• you need to flush object-cache after scrubbing otherwise old objects remain in cache
• use random domains in data file to avoid using real domains and eventually triggering emails or other interaction with real people
• add db-size check to avoid using this method on massive dbs and allow bypass only with cli option or filter.
• can't see any need for rewrite_rule flush.
• for scrub_comments() the way it is right now you could as well just truncate the tables.
• https://github.com/10up/wp-scrubber/blob/develop/includes/classes/class-wp-cli-command.php#L236 * by default we should generate random passwords and not just default to "password"

[gthayer]

add db-size check

• I've set the default limit at 2GB, added an argument to bypass the warning, and added a filter to change the base value if needed.
• I'm not sure what a good default should be. I feel like a lot of projects will hit 2GB limit.
• The main performance drag in the core plugin is based on the number of users. I ran this on a 2GB site, but they only have 400 users, and the scripts were completed in just a few seconds.

• I feel 2GB might be a good place for now, then we can bump it one way or another depending on how it does in the wild.

  for scrub_comments() the way it is right now you could as well just truncate the tables.

  • I'm aware. I feel that section should be fleshed out later and I wanted to keep the "copy, modify, replace" approach.