PHPCS reporting error on dependent library nikic/php-parser, hamcrest/hamcrest-php

10up / wp_mock

WordPress API Mocking Framework

https://wp-mock.gitbook.io

Other

676 stars 70 forks source link

PHPCS reporting error on dependent library nikic/php-parser, hamcrest/hamcrest-php #251

Open sfgourav opened 2 months ago

sfgourav commented 2 months ago

Bug report

Need update of dependent libraries to support php 8.2+

Replication steps

If we run phpcs on the repo we see the following errors

Expected behavior

support for dependent libraries for php8.2+

nmolham-godaddy commented 2 months ago

Thanks @sfgourav for reporting this potential issue with php 8.2. according to composer.lock WP_Mock using the latest release version of hamcrest/hamcrest-php package https://github.com/hamcrest/hamcrest-php/releases/tag/v2.0.1 which it about 4 years old. But as far as I can tell the hex value is still valid, don't you think?

FYI: I found there is an issue already open for that error => https://github.com/hamcrest/hamcrest-php/issues/78