10up / wpcli-vulnerability-scanner

WP-CLI command for checking installed plugins and themes for vulnerabilities reported on wpvulndb.com
MIT License
278 stars 40 forks source link

Change plugin slug #40

Closed oscarssanchez closed 3 years ago

oscarssanchez commented 5 years ago

Description of the Change

It looks like there is a plugin on the .org repo that is already using this plugin slug, it is causing issues as described in https://github.com/10up/wp-vulnerability-scanner/issues/36 , mainly confusion when there is a plugin upgrade.

This PR just changes de slug of the plugin to 10up-wp-vulnerability scanner to prevent this

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

Applicable Issues

jeffpaul commented 4 years ago

@oscarssanchez per @TheLastCicada input, can you update the naming to wpcli-vulnerability-scanner?

pabamato commented 3 years ago

@TheLastCicada Updating the slug still shows the "update available" message pointing to the wrong plugin. Since the .org plugin API uses the folder name as a slug, could be the case that we need to use a different plugin folder name. Updating the plugin folder name, means that for manual installation, we need to specify the destination folder or update this repo name to match.

jeffpaul commented 3 years ago

Closing in favor of #49