search

10up / wpcli-vulnerability-scanner

WP-CLI command for checking installed plugins and themes for vulnerabilities reported on wpvulndb.com
MIT License
274 stars 40 forks source link

Introduce class autoloading #82

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

WP-CLI commands are Composer-loaded. So using Composer's autoloader is natural.

Look how nice it became: https://github.com/10up/wpcli-vulnerability-scanner/blob/ca0190e214224ec2cb9e70a453ca54f62632ec02/wpcli-vulnerability-scanner.php

jeffpaul commented 1 year ago

Thanks for the contribution @szepeviktor, we'll get this through review and respond here with any questions/concerns.

iamdharmesh commented 1 year ago

Hi @szepeviktor,

Thanks for the contribution and working on this. We have open PR #78 which already covers these changes. To avoid git conflicts we are more likely to continue with #78 and close this. Could you please help to review #78 once if you have any feedback on autoloading there?

Thanks again for the contribution.

szepeviktor commented 1 year ago

All right. I wouldn't be in your place to meet people who install commands as plugins.

- 10up WP-CLI Vulnerability Scanner
+ 10up Vulnerability Scanner Command

This is a more appropriate name. Just for inspiration!