Fix action failure - Githubissues

10up / wpcs-action

GitHub Action to help you lint your PHP without additional dependencies within your codebase

MIT License

54 stars 13 forks source link

Fix action failure #20

Closed cadic closed 1 year ago

cadic commented 1 year ago

Description of the Change

The action has failed multiple times in the recent.

This PR locks the docker image to PHP 7.4 which should be compatible with WPCS release: https://github.com/WordPress/WordPress-Coding-Standards/issues/2035#issuecomment-1077737225

How to test the Change

Tested on a temporary draft PR: https://github.com/10up/simple-podcasting/actions/runs/3428909916/jobs/5713819898 The test failures are correct (since it's not possible to use 10up-Default ruleset with wpcs-action yet)

The annotations work as expected: https://github.com/10up/simple-podcasting/pull/196/files

Changelog Entry

Fixed - Action failure with PHP8

Checklist:

[ ] I agree to follow this project's Code of Conduct.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my change.
[ ] All new and existing tests pass.

jeffpaul commented 1 year ago

@iamdharmesh @dkotter @dinhtungdu any concerns merging this in and tagging a minor release to help resolve this for folks running this action?