10up / wpsnapshots

(DEPRECATED) A project sharing tool for WordPress.
MIT License
216 stars 21 forks source link

Adds a progress bar #41

Closed ChaosExAnima closed 3 years ago

ChaosExAnima commented 6 years ago

Fixes #27. Adds a progress bar to track S3 uploads and downloads.

@tlovett1 - What's the best way to test this? The dev environment here isn't clear to me.

tlovett1 commented 6 years ago

Hey @ChaosExAnima, this is awesome! There isn't any dev environment. I'll test.

ChaosExAnima commented 6 years ago

@tlovett1 - Okay! I may spend some time next week adding a dev environment via Docker. If there's a test AWS bucket/db I can use that'd be appreciated :)

ChaosExAnima commented 5 years ago

@tlovett1 - Any word here? I'd love to get this up on Docker Hub as a beta for testing in projects.

tlovett1 commented 5 years ago

@ChaosExAnima I feel like if we are adding one progress bar, we should add them everywhere anything is time consuming:

What are your thoughts? I'll ping you separately about the Docker thing.

ChaosExAnima commented 5 years ago

I think that's totally doable. May be good to make a Progress class to handle this and inject that into the appropriate locations.

Note though this PR adds a progress bar for both downloads and uploads, pretty much any operation on AWS. I can hook up local FS operations too, though.

tlovett1 commented 5 years ago

Yea agreed we probably want to abstract out the progress bar code a bit. Want to update the PR with adding the progress bar to the entire list?

ChaosExAnima commented 5 years ago

Hey @tlovett1! I've implemented the progress bar across most operations as a generic class. If you can review when you get a sec, I would appreciate it!

jeffpaul commented 4 years ago

@tlovett1 any updates from your review on this one?

jeffpaul commented 4 years ago

@tlovett1 any updates on your review of this PR?

ChaosExAnima commented 4 years ago

Hey @jeffpaul! I'm no longer using this tool nor have any access to this repo, so I am not in a position to respond to issues.