Closed felipeelia closed 4 years ago
Also putting in my vote to have --column-statistics=0 --no-tablespaces
as it is also not present in MariaDB 10.3.x releases which is what all the current major Linux operating systems use by default (Ubuntu, Debian and CentOS/RHEL)
Description of the Change
This PR reverts some of the changes introduced in #66 and is supposed to be just a hotfix, as we have an underlying issue that still needs to be solved.
The
--column-statistics=0 --no-tablespaces
parameters make sense while using newer versions of mysqldump. In WP Local Docker we are using v5.5. WP Local Docker ultimately extends debian:buster and stated here it doesn't content recent versions of mysql-client tools.Alternate Designs
Hopefully, we can develop a solution that conditionally adds those parameters based on the mysqldump version being used.
Benefits
WP Snapshots working again on WP Local Docker.
Possible Drawbacks
It generates some errors for users using it outside WP Local Docker (and with newer versions of mysqldump)
Verification Process
It's very difficult to test this, so I'm just reverting the mysqldump calls to what they were before.
Checklist:
Applicable Issues
Changelog Entry