10up / wpsnapshots

(DEPRECATED) A project sharing tool for WordPress.
MIT License
215 stars 22 forks source link

Fix: Unable to skip overwriting local snapshot using one line command #86

Open dinhtungdu opened 3 years ago

dinhtungdu commented 3 years ago

Description of the Change

This PR applies the approach of --include_files to the --overwrite_local_copy flag to make it skippable without prompt.

Verification Process

  1. cd to a WordPress directory.
  2. Pull a snapshot using wp pull <snapshot_id>.
  3. See the prompt whether to overwrite the local snapshot.
  4. Ctrl-C to abort the command.
  5. Pull a snapshot using wp pull <snapshot_id> --overwrite_local_copy=false.
  6. See the pull runs without overwrite local copy prompt.
    • [ ] I have read the CONTRIBUTING document.
    • [ ] My code follows the code style of this project.
    • [ ] My change requires a change to the documentation.
    • [ ] I have updated the documentation accordingly.
    • [ ] I have added tests to cover my change.
    • [ ] All new and existing tests passed.

    Applicable Issues

    Closes #85.

    Changelog Entry

    Fixed: Allow skipping --overwrite_local_copy without prompt.

jeffpaul commented 1 year ago

@eugene-manuilov @tlovett1 let me know if there's intent to take action on this PR or if we should close it out?