Open dustinrue opened 2 years ago
To test this you would need to update the images value in wp-local-docker to ensure this image, where ever it lives, it used. I have a test version of this at https://hub.docker.com/repository/docker/dustinrue/wp-snapshots
I was able to test this and it solves a couple of important problems.
This is the process I used to test.
apt-get update &&
as noted in this comment https://github.com/10up/wpsnapshots/pull/92#discussion_r881725070 docker build -t 10up/wpsnapshots:latest . --build-arg WPSNAPSHOTS_ARCHIVE="https://github.com/10up/wpsnapshots/archive/refs/tags/2.2.1.tar.gz"
This worked for me and I think this should be merged and deployed once the apt-get update part is added so it will build successfully. Until then, I'll be writing instructions for my team to update their local image to a working version.
As a side note, might be a good idea to have multiple versions tagged for php version so that projects using php 8 and even php 8.1 can work correctly. This would require an update for 10up local docker so the php version of the project affects the version used to run snapshots.
Description of the Change
This PR modifies the Dockerfile and build routines (actions) to:
Alternate Designs
Benefits
Full native speed for Apple M1
Possible Drawbacks
Verification Process
I'm unable to fully test this
Checklist:
Applicable Issues
Changelog Entry