110yards / fantasy

MIT License
2 stars 0 forks source link

National Status Bug #188

Open bohsask opened 2 years ago

bohsask commented 2 years ago

Hi, our league has been noticing that the Maple Leaf (National) symbol is incorrect for a number of players. It does not match what the player's actual status is on the CFL website. Is this an issue with the code on the website or the CFL's data? I thought we had flagged this bug earlier but I can't find the post...

A couple of high profile examples are Cody Fajardo and Eugene Lewis.

mdryden commented 2 years ago

Sorry, but this is an issue with the CFL's data and there's nothing I can do about it currently.

I'm not sure why it doesn't match the CFL's site, they must have some special sauce for themselves.

This is what Fajardo looks like in the CFL's data:

{
            "cfl_central_id": 160140,
            "stats_inc_id": 557390,
            "first_name": "Cody",
            "middle_name": "",
            "last_name": "FAJARDO",
            "birth_date": "1992-03-29",
            "birth_place": "Los Angeles, California",
            "height": "6.02",
            "weight": 215,
            "rookie_year": 2016,
            "foreign_player": false,
            "image_url": "http://d3ham790trbkqy.cloudfront.net/wp-content/uploads/players/c/cody-fajardo-160140.png",
            "school": {
                "school_id": 414,
                "name": "Nevada"
            },
            "position": {
                "position_id": 1,
                "offence_defence_or_special": "O",
                "abbreviation": "QB",
                "description": "Quarterback"
            },
            "team": {
                "is_set": true,
                "team_id": 7,
                "location": "Saskatchewan",
                "nickname": "Roughriders",
                "abbreviation": "SSK",
                "season": 2022,
                "uniform": 7
            }
        }

Note "foreign_player": false, - this is the field which controls the maple leaf icon.

bohsask commented 2 years ago

Are we able to get ahold of the CFL's statistician or IT people? If we provide a complete list of the incorrect "foreign player" records, maybe we can get them to fix them.

bohsask commented 2 years ago

It is strange that their data doesn't match what's on their own website. They must have a separate database for their CFL player page? Here are the ones that are incorrect on our rosters: Cody Fajardo Larry Dean Pete Robertson Steven Dunbar Eugene Lewis Loucheiz Purifoy Darnell Sankey Shawn Bane Stefen Banks Wynton Mcmanis Markeith Ambles DaVaris Daniels

mdryden commented 2 years ago

I can send them an email, but unfortunately, since Sully left they haven't been very responsive to me.

mdryden commented 2 years ago

I've emailed the CFL about this. If they fix it, I will many any necessary adjustments in the site to correct it.