search

110yards / fantasy

MIT License
2 stars 0 forks source link

Some players are not marked as injured (eg: Andrew Harris) #28

Closed mdryden closed 3 years ago

mdryden commented 3 years ago

Please watch here for updates, I will find an fix for this before tomorrow's game.

mdryden commented 3 years ago

Unfortunately, I don't have a quick fix for this one - I use the team roster pages (eg: https://www.bluebombers.com/roster/) as the data source for player statuses, and it appears that these aren't updated in a timely fashion, at least not for last minute scratches like Harris appears to be.

For now, I'm going to have to go with the same "fix" as last year, where the IR is a honor system within the leagues, and any player can be placed in those slots. If I can come up with a better solution, I'll update this ticket.

mdryden commented 3 years ago

I think I've come up with a better fix for this one:

At some point before the game starts, the official rosters are added to the game data. I can use that data when updating players to identify players who are active according to the official team roster, but scratched from the game. I'll set those players' status to "OUT", and then they will be eligible for IR. This will likely mean last minute roster changes, but that's part of the fun with Fantasy I'd say.

I need to do some testing on this one before I roll it out, to make sure it works the way I think it will, and that the statuses are updated early enough for people to actually make IR changes, but I think it will work.

I'd say expect to see this around week 3.

mdryden commented 3 years ago

Deploying a test fix for this one this week.

The following players on the CGY and BC rosters are removed from the active roster for today's game, this update should mark them as Inactive unless they are already inactive for another reason:

BC - Hammond BC - Mathews BC - Aruna

CGY - Pfeffer CGY - Riley CGY - Branch CGY - Wall CGY - Bell

If this works ok, then next week I'm going to roll out a commissioner option that makes the IR strict or relaxed. I'll default all leagues to strict IR, and leagues will be able to opt back out.

mdryden commented 3 years ago

I think it worked? A few of those players aren't in the player list (eg: Mathews) - not sure if it's a typo in the roster PDF, or if they never actually made it onto the team long enough to show up.

mdryden commented 3 years ago

Noticed that the roster matchup scores weren't updating (players are, but not the roster score).

This is fixed, but on mobile may take a bit to appear if using Chrome.