110yards / fantasy

MIT License
2 stars 0 forks source link

2nd round playoff matchups incorrect #74

Closed mdryden closed 2 years ago

mdryden commented 3 years ago

It appears that in some leagues, playoff winners weren't properly carried over to this week.

I will investigate and ensure the matchups are corrected before any games start this week.

Apologies guys, it's tough to test certain parts of the system until they actually happen.

mdryden commented 2 years ago

The bug here was that the calculator was using total points for instead of current week's points for to figure out the winner - just a mistake on my part. 2/3 leagues which started last week actually ended up being accidentally correct, since the favorites won. Only the 1 league was incorrect (which I was probably lucky to spot first), because there was an upset.

I have re-run the playoffs calculation and all leagues are correct now.

EElks commented 2 years ago

Thanks Michael. We were hoping to have a third place game between the losers of the semi final games. Is this possible to set up? Thanks.

mdryden commented 2 years ago

Sorry, but it's not possible in the site currently. I'll take that under consideration for next year though; a loser bracket basically, I guess?

In the meantime, teams will still accumulate points even if they don't have a matchup. You could figure out a winner manually if you wanted.

EElks commented 2 years ago

Thanks Michael. We like to have a third place game, something to consider for next year.

I think we'll do it manually for the upcoming weekend.

Thanks for the great season. We're happy with the site overall and look forward to joining next year.

Matt

On Wed., Oct. 27, 2021, 1:05 p.m. Michael Dryden, @.***> wrote:

Sorry, but it's not possible in the site currently. I'll take that under consideration for next year though; a loser bracket basically, I guess?

In the meantime, teams will still accumulate points even if they don't have a matchup. You could figure out a winner manually if you wanted.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mdryden/110yards/issues/74#issuecomment-953226554, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVCSEJXHSVA6YO3L55Y6QR3UJBEPLANCNFSM5GVHWDQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.