SotR cast rate output from FSM buggy?

[GoogleCodeExporter]

Run:
c=build_config('hit',2,'exp',2,'queue','SotR>CS');
[c.rot.hpg/3 c.rot.cps(8)]

ans =

    0.0604    0.0741

The SotR cast rate is consistently 22.7% higher than the HPG rage 
(ans(2)/ans(1)=1.2270).  It sill occurs with longer queues (i.e. 'SotR>CS>J', 
'SotR>CS>J>AS', etc.) and the ratio is always 22.7% for 2% hit and exp. 

Note that c.rot.cps(8) matches the actionPr output for SotR, so the error must 
lie somewhere within the FSM code.  I've double-checked that the HPG rate is 
correct (based on CS and J cast rates and miss percentages).  

Interestingly, the ratio seems to depend on hit/exp.  At 7.5% hit, 7.5% exp, 
the ratio is 1.0811, which is (probably not coincidentally) 1/0.9250, or 
1/(1-0.075), where 0.075 is the remaining chance to be parried.  

As such, my assumption is that actionPr is errantly dividing SotR cast rates by 
an extra factor of mdf.mehit.

Original issue reported on code.google.com by theckhd on 14 Apr 2012 at 10:37

[GoogleCodeExporter]

Does MoP SotR consume HP on hit, or on cast? SotR HP consumption currently uses 
the cata model of on-hit SotR HP consumption which explains the increased SotR 
cast rate for low hit/expertise.

Given MoP SotR is now off the GCD, I presume SotR now consumes HP on-cast, yes?

Original comment by iminmm...@gmail.com on 26 Apr 2012 at 11:57

[GoogleCodeExporter]

It's supposed to consume it on cast, though recent beta builds reversed this 
(but still granted the buff - hence why it's probably a bug).  For now, I'd 
assume that it will end up being on-cast, because it doesn't make sense as an 
on-hit ability anymore.

Original comment by theckhd on 27 Apr 2012 at 1:41

[GoogleCodeExporter]

Rev 453: Updated to consume HP & proc buff On-cast

Original comment by iminmm...@gmail.com on 27 Apr 2012 at 10:49

• Changed state: Fixed