search

117503445 / GoWebDAV

a lightweight, easy-to-use WebDAV server
GNU General Public License v3.0
147 stars 29 forks source link

Some features #27

Closed Jipok closed 8 months ago

Jipok commented 8 months ago

I want to slightly modify the frontend to suit my needs. For example, remove unnecessary buttons and add ,y own. With this flag, I don’t have to rebuild the project and upload it to the server every time there is a change.

With this PR, I think I achieved everything I wanted from GoWebDAV. And most likely I won’t bother you anymore.

Jipok commented 8 months ago

Another feature that I was missing was the ability to share a server without a login and password. Just a link. By adding index hiding I achieved security when hosting the server publicly. Without knowing the link, you will not be able to get any response from the server. Link example: https://webdav.mydomain.org/HjWi2pnyJws29uw7G

While implementing this feature, I noticed that after refactoring you added enableSingleDavMode. I tried for a long time to understand why it was needed, but I couldn’t. I removed the code associated with this and the server behavior did not change at all. I tested with: 1) The only ones dav / 2) The only dav /somename 3) Two different davs 4) Two davs, one /. Here, as expected, the server threw an error indexHandler works correctly in all cases.

Jipok commented 8 months ago

In fact, I needed a different ui just to not display the buttons for read-only mode. I'll redo it tomorrow.

Jipok commented 8 months ago

The latest commit allows this: --dav "/secret1,../dir1; /secret2,./dir2;" Backward compatibility is guaranteed.

Jipok commented 8 months ago

@117503445 I'm done with this

117503445 commented 8 months ago

Thank you very much for your contribution, but I found that after accessing readonly and then writeable, the page is still readonly. Now I have temporarily rolled back the readonly code, can you fix this?

Jipok commented 8 months ago

A separate code for the read-only version is no longer needed. I made changes to the front itself and it now independently determines write access. https://github.com/dom111/webdav-js/pull/132

Since the project has been inactive for several years, I would not hope for a quick acceptance of the PR. Perhaps he will not be accepted at all. Therefore, I recommend specifying a link to the fork in the build script: https://github.com/Jipok/webdav-js

117503445 commented 8 months ago

A separate code for the read-only version is no longer needed. I made changes to the front itself and it now independently determines write access. dom111/webdav-js#132

Since the project has been inactive for several years, I would not hope for a quick acceptance of the PR. Perhaps he will not be accepted at all. Therefore, I recommend specifying a link to the fork in the build script: https://github.com/Jipok/webdav-js

done