search

117HD / RLHD

Old School RuneScape GPU renderer with a suite of graphical enhancements.
BSD 2-Clause "Simplified" License
52 stars 45 forks source link

Vanilla shading reversal on tiles breaks snow hue and brightness #223

Open SirFancyBacon opened 1 year ago

SirFancyBacon commented 1 year ago

Describe the bug When blending is enabled white level appears to be capped at a certain brightness where tiles like snow meet something dark; baked in shadow or dark tile; causing a negative visual impact. See screenshots

To Reproduce Steps to reproduce the behavior:

  1. Go to Fishing Hamlet or ice caves within Goblin Village
  2. Click on Toggle ground blending and see the difference in snow colors

Expected behavior A more accurate blending of colors

Screenshots image image

Environment (please complete the following information):

SirFancyBacon commented 1 year ago

Setting the color of the snow with .setBrightness() may resolve this issue; Will require tuned material for each area i suspect.

A hacky but workable solution

SirFancyBacon commented 1 year ago

Follow up: it did not work :(

aHooder commented 1 year ago

We could do the same as we did for legacy grey colors potentially: image

image

SirFancyBacon commented 1 year ago

Would we then want to make the environments respect that setting then? I am sure we are going to want to go touch up a lot of snow areas won't we change this setting

aHooder commented 12 months ago

Since snow is partly fixable by overriding lightness, I'll repurpose this issue for some kind of solution to issues surrounding vanilla shading reversal on tiles.