117HD / RLHD

Old School RuneScape GPU renderer with a suite of graphical enhancements.
BSD 2-Clause "Simplified" License
51 stars 44 forks source link

Moons of Peril Draft #411

Closed Jin-Jiyunsun closed 1 month ago

Jin-Jiyunsun commented 4 months ago

WIP Antechamber general: java_ZAQ3XsskZU java_x4EFkiIWIw

Eclipse braziers: java_AZEq18vcZC java_82RgBK5DnO They look a little less sad now.

Ancient shrine: java_BSZBsTchUq java_p4wm0ymGXN

Blood Moon entrance: java_6BINSww3ia java_lq3xztju7S

Blue Moon entrance: java_t20jKLsKwW java_gUx89xjiGD

Eclipse Moon entrance: java_CAv9LzMlp2 java_EHEWMjtM2B

Eclipse Moon arena: java_pZAhOSCf1g java_YfVCZGuvfR

Giants Den: java_8hmndlrxRc java_DAr3ZLbMQ4

Cam Torum stuff: java_CvDDxgSe5u java_mUdKgYXo5h

Closes: #410

aHooder commented 2 months ago

I've done a run of perilous moons to have a look, and almost everything seems pretty solid :+1:. I'm on the fence about attaching lights to all of the tiny fires making up those temporary flame walls, since that's a lot of lights. These mushroom lights are a bit too bright or too short radius too (and they need a better name ofc): image

Jin-Jiyunsun commented 2 months ago

I took the liberty to update this PR, hope that's fine 🙂 What's left to do for this PR in your view?

Of course! This was right before I took my month long break so I kinda forgot what I had left to do, I think it was something something to do with tie overrides in the entrance hall with the big D20 since the floor looks like tiles and it currently is just dirt, I think it was pretty much ready for merging besides that and the couple issues you brought up

Jin-Jiyunsun commented 2 months ago

I've done a run of perilous moons to have a look, and almost everything seems pretty solid 👍. I'm on the fence about attaching lights to all of the tiny fires making up those temporary flame walls, since that's a lot of lights. These mushroom lights are a bit too bright or too short radius too (and they need a better name ofc): image

Ah and regarding the lights on the fires, yeah it is a lot but it does make it look quite a bit better imo, is it possible to define world positions for lights and only have them show if a particular object is on screen?

Jin-Jiyunsun commented 2 months ago

This should be ready for review, maybe do another run through and double check the areas you pointed out before? As for the lights on the long lines of fires, if you deem them too excessive just snip them out before merging and we can revist it later.